Fix base color calculation for 3D Tile styles #12060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @jjhembd! ✅ We can confirm we have a CLA on file for you. |
|
Awesome, I can confirm this fixes the specs. Thanks @jjhembd! |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #12043, we have separate properties on
czm_modelMaterialfor the materialbaseColorand the computeddiffuselighting result.Since CPU styling is applied before lighting calculations, it should now modify the
baseColorratherdiffuse. This explains a few spec failures when running locally.Issue number and link
Testing plan
Run Cesium3DTilesetSpec locally
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change