Ellipsoid Tangent Plane #1150
Merged
Ellipsoid Tangent Plane #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This partially fixes #620, but I'm not sure the resulting polygon is rendering correctly. You might want to check that out too (sample code in the biug) |
| @@ -119,6 +118,10 @@ define([ | |||
| Cartesian3.normalize(cartesian, ray.direction); | |||
|
|
|||
| var intersectionPoint = IntersectionTests.rayPlane(ray, this._plane, projectPointOntoPlaneCartesian3); | |||
| if (!defined(intersectionPoint)) { | |||
There was a problem hiding this comment.
Perhaps it is obvious, but you'll have to explain this to me. How does switching the ray's direction help?
|
@bagnell explained it to me. We're good here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ellipsoid tangent planes for ellipsoids other than the unit sphere. See the discussion in #1121.