Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated API for 1.107 #11379

Merged
merged 5 commits into from
Jul 3, 2023
Merged

Remove deprecated API for 1.107 #11379

merged 5 commits into from
Jul 3, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jun 29, 2023

Fixes #11195
Fixes #11259
Fixes #11375

Removes deprecated APIs and cleanup corresponding specs in preparation for the 1.107 release.

TODO:

  • Fix I3SDataProvider and related specs
  • Fix TS errors
  • Merge main

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor Author

ggetz commented Jun 30, 2023

For the most part, this was a pretty wrote find & remove/replace. There were some updates needed to unit tests in order to ensure everything was up to date with the newer APIs. In particular, I3S specs needed some significant cleanup due to tightly coupled specs. I removed a few specs which were really testing mocks more than the actual classes.

@jjhembd I think this is ready for review.

@ggetz ggetz requested a review from jjhembd June 30, 2023 17:49
Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz, this looks good to me! There were a couple things in the voxels sandcastle that still looked like the old API. I pushed a quick fix for those.
Once CI passes, I think this is ready to merge.

@jjhembd jjhembd merged commit dc370b7 into main Jul 3, 2023
@jjhembd jjhembd deleted the remove-ready branch July 3, 2023 12:48
@ggetz
Copy link
Contributor Author

ggetz commented Jul 3, 2023

Thanks @jjhembd!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants