Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix credit display for hidden imagery layers #11349

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Jun 12, 2023

Fixes #11340

To test:

Use this minimal Sandcastle:

const viewer = new Cesium.Viewer("cesiumContainer", {geocoder: false});
viewer.imageryLayers.get(0).show = false;

The Bing maps logo still shows up in Attribution even though it's impossible for it to show up in the scene.

@ggetz ggetz requested a review from jjhembd June 12, 2023 19:08
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz
Copy link
Contributor Author

ggetz commented Jun 16, 2023

@jjhembd Would you mind taking a look?

Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz! The changes make sense, and the credit is fixed on my end.

@jjhembd jjhembd merged commit 840debf into main Jun 16, 2023
@jjhembd jjhembd deleted the imagery-no-show-credits branch June 16, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Credits for imagery layer shows up even when layer is hidden
3 participants