Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Google Photorealistic 3D Tiles #11275

Merged
merged 1 commit into from
May 10, 2023
Merged

Updates for Google Photorealistic 3D Tiles #11275

merged 1 commit into from
May 10, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented May 10, 2023

This PR

  • adds two basic Sandcastles demonstrating Google's Photorealistic 3D Tiles.
  • addscreateGooglePhotorealistic3DTileset to create a 3D tileset streaming Google Photorealistic 3D Tiles.
  • adds GoogleMaps for managing credentials when loading data from the Google Map Tiles API.
  • updates RequestScheduler.requestsByServer, to allow for more simultaneous requests to this API.
  • updates the release guide with instructions for updating the api key each release

@ggetz ggetz requested a review from jjhembd May 10, 2023 18:35
@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz ggetz marked this pull request as ready for review May 10, 2023 18:35
Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ggetz!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants