Ensure offCenterFrustum's values are updated #11210
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where calling the following functions in immediate succession would result in an
DeveloperError: normalized result is not a number
.As illustrated in this forum post.
This was because the values of
_offCenterFrustum
were not up to date. To remedy this, I made a getter for external use which callsupdate
, and updated the external references to the property, ensuring they are called once to avoid running the update function multiple times (though it shouldn't be too much overhead regardless, which is why other getters do the same).I also re-ordered the specs such that they should now fail if offCeneterFrustum values are not up to date.