Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set depthTestAgainstTerrain when using the viewer with baseLayerPicker enabled #11207

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Set depthTestAgainstTerrain when using the viewer with baseLayerPicker enabled #11207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/engine/Source/Scene/DepthPlane.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ DepthPlane.prototype.update = function (frameState) {

const context = frameState.context;

// Allow offsetting the ellipsoid radius to address rendering artefacts below ellipsoid zero elevation.
// Allow offsetting the ellipsoid radius to address rendering artifacts below ellipsoid zero elevation.
const radii = frameState.mapProjection.ellipsoid.radii;
const ellipsoid = new Ellipsoid(
radii.x + this._ellipsoidOffset,
Expand Down
2 changes: 2 additions & 0 deletions packages/widgets/Source/Viewer/Viewer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,6 +720,8 @@ Either specify options.terrainProvider instead or set options.baseLayerPicker to

if (createBaseLayerPicker) {
baseLayerPicker.viewModel.selectedTerrain = undefined;
// Required as this is otherwise set by the baseLayerPicker
scene.globe.depthTestAgainstTerrain = true;
}

scene.setTerrain(options.terrain);
Expand Down