-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure spec parity between Model
and ModelExperimental
#10600
Conversation
Thanks for the pull request @j9liu!
Reviewers, don't forget to make sure that:
|
3029209
to
d1a4dcb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j9liu specs are running fine though when I compare the spec lists looks like there's quite a few tests the old Model
had that aren't in ModelExperimental
. Maybe that was intentional (e.g. some render tests might be better handled in other files) but wasn't sure.
Two things to note from this PR:
|
@ptrgags updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j9liu almost there, just a couple comments!
@ptrgags updated! |
Updates look good, thanks @j9liu! |
This PR reorganizes
ModelExperimentalSpec
, and adds a handful of new specs toModelExperimental
and related classes. These are specs fromModelSpec
that didn't have existingModelExperimental
counterparts.There are two
xit
-ed unit tests. We need to return to these later and fix them:For comparison, here's how the latter test looks:
Model
ModelExperimental