Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable blur active element #10518

Merged
merged 10 commits into from
Jul 8, 2022

Conversation

yonzmeer
Copy link
Contributor

@yonzmeer yonzmeer commented Jul 6, 2022

This PR comes to make the behavior introduced in #8662 configurable via the viewer constructor options.

When the canvas is clicked, it will not blur the active element if false is provided.

The default value is true so the original behavior remains.

It comes to solve issues #10185 and #9134.

Task list

  • find a better name for the viewer options argument

@cesium-concierge
Copy link

Thank you so much for the pull request @yonzmeer! I noticed this is your first pull request and I wanted to say welcome to the Cesium community!

The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.

  • ❌ Missing CONTRIBUTORS.md entry.
  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@yonzmeer
Copy link
Contributor Author

yonzmeer commented Jul 6, 2022

I'm not sure about my naming. this behavior is too specific for me to find a good name.
Would like some help with that (:

@ggetz
Copy link
Contributor

ggetz commented Jul 6, 2022

Hi @yonzmeer, can you please send in a Contributor License Agreement? That needs to be signed before we can review anything. Thanks!

@yonzmeer
Copy link
Contributor Author

yonzmeer commented Jul 6, 2022

Hi @yonzmeer, can you please send in a Contributor License Agreement? That needs to be signed before we can review anything. Thanks!

done

Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yonzmeer! I have a few comments on the approach:

Source/Widgets/CesiumWidget/CesiumWidget.js Outdated Show resolved Hide resolved
@yonzmeer yonzmeer requested a review from ggetz July 6, 2022 21:39
CHANGES.md Outdated Show resolved Hide resolved
@yonzmeer yonzmeer requested a review from ggetz July 8, 2022 13:21
@yonzmeer yonzmeer requested a review from ggetz July 8, 2022 15:19
@ggetz
Copy link
Contributor

ggetz commented Jul 8, 2022

Thanks @yonzmeer! I used the example from #9134 to test, and this is working well.

@ggetz ggetz merged commit 9fcaf79 into CesiumGS:main Jul 8, 2022
@yonzmeer yonzmeer deleted the configurable-blur-active-element branch July 8, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants