-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configurable blur active element #10518
Configurable blur active element #10518
Conversation
Thank you so much for the pull request @yonzmeer! I noticed this is your first pull request and I wanted to say welcome to the Cesium community! The Pull Request Guidelines is a handy reference for making sure your PR gets accepted quickly, so make sure to skim that.
Reviewers, don't forget to make sure that:
|
I'm not sure about my naming. this behavior is too specific for me to find a good name. |
Hi @yonzmeer, can you please send in a Contributor License Agreement? That needs to be signed before we can review anything. Thanks! |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yonzmeer! I have a few comments on the approach:
This PR comes to make the behavior introduced in #8662 configurable via the viewer constructor options.
When the canvas is clicked, it will not blur the active element if false is provided.
The default value is true so the original behavior remains.
It comes to solve issues #10185 and #9134.
Task list