Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New version of "purify" declares a source map, but it's not included in Cesium source #9424

Open
reliable-casey opened this issue Mar 11, 2021 · 1 comment
Open

New version of "purify" declares a source map, but it's not included in Cesium source #9424

reliable-casey opened this issue Mar 11, 2021 · 1 comment
Labels
category - tooling

Comments

@reliable-casey
Copy link

reliable-casey commented Mar 11, 2021 •
edited
Loading

#9241 upgrades the purify library which declares a source map here: 4d4892b#diff-1b4d88e996ee00af5f71adfe5aafd9188412f0990b0d1d90fa58c12c1477edd3R1159

However the source map is not included in the Cesium codebase, so I'm getting a 404 warning during development:

DevTools failed to load SourceMap: Could not load content for .../Cesium/Source/ThirdParty/purify.es.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

This is just an annoyance, nothing is broken. Thanks in advance!

cc @mramato
@reliable-casey reliable-casey changed the title #9241 introduces new version of "purify" declares a source map here, but it's not included in Cesium source New version of "purify" declares a source map, but it's not included in Cesium source Mar 11, 2021
reliable-casey referenced this issue Mar 11, 2021
@mramato
Update DOMPurify to 2.2.2
4d4892b 
We were very out of date and this addresses several potential OWASP
vulnerabilities. Fixes #9240
@matthias-ccri
Copy link
Contributor

matthias-ccri commented May 25, 2021 •
edited
Loading

Currently warns about three missing sourcemaps:

webpack:///node_modules/cesium/Source/ThirdParty/purify.es.js.map
webpack:///node_modules/cesium/Source/ThirdParty/protobuf.js.map
webpack:///node_modules/cesium/Source/ThirdParty/Autolinker.js.map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - tooling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ggetz @matthias-ccri @reliable-casey