Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OWASP vulnerabilities due to outdated dependency #9240

Closed
areyes05 opened this issue Nov 17, 2020 · 3 comments · Fixed by #9241
Closed

OWASP vulnerabilities due to outdated dependency #9240

areyes05 opened this issue Nov 17, 2020 · 3 comments · Fixed by #9241

Comments

@areyes05
Copy link

A scan using the OWASP dependency-check reveals that Cesium uses DOMPurify 1.0.8 which has several vulnerabilities that were patched on release 2.2.2.

  • Fixed an mXSS-based bypass caused by nested forms inside MathML (RETIREJS)
  • Fixed another bypass causing mXSS by using MathML
  • Fixed several possible mXSS patterns, thanks @hackvertor (RETIREJS)

Could it be possible to update this dependency so that Cesium will not be vulnerable?

I also recommend adding a security policy on GitHub so that the contributors can get a chance to address this issues before making it public.

Thanks

AR

mramato added a commit that referenced this issue Nov 17, 2020
We were very out of date and this addresses several potential OWASP
vulnerabilities. Fixes #9240
@mramato
Copy link
Contributor

mramato commented Nov 17, 2020

Thanks for reporting this @areyes05, I just opened #9241 with a fix. I will write up another issue to look into using dependency-check either in our release process or as part of CI (depending on how long it takes) and a third issue for adding a security policy.

Thanks again.

This was referenced Nov 17, 2020
@areyes05
Copy link
Author

I am impressed by how soon you tackled this and I am thrilled by Cesium adding the dependency-checker to the release process.

Great work!

@reliable-casey
Copy link

@mramato This new version of purify declares a source map here: 4d4892b#diff-1b4d88e996ee00af5f71adfe5aafd9188412f0990b0d1d90fa58c12c1477edd3R1159

However the source map is not included in the Cesium codebase, so I'm getting a 404 warning during development:

DevTools failed to load SourceMap: Could not load content for .../Cesium/Source/ThirdParty/purify.es.js.map: HTTP error: status code 404, net::ERR_HTTP_RESPONSE_CODE_FAILURE

Is this something you want a new issue ticket for? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants