-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DistanceDisplayCondition point in the middle of the Viewer #7557
Comments
I can absolutely reproduce this on Linux (Nvidia) and also via Cesium ion (the tileset position tool ends up with a large phantom point). |
I forgot to mention this before, but I had messed around with this a few months ago and I had written down that v384.111 was the last Nvidia driver without this problem. I don't have a free machine to verify this again though. |
Fixed via above PR |
The above PR does not fix this issue on my CentOS machine. Using the same Sandcastle example I can still reproduce the issue. @mramato does the original Sandcastle example not exhibit any issues for you anymore? |
Looks like this is indeed back. @OmarShehata didn't you fix an issue with how we hide points vs alpha or something recently with a shader? @lilleyse any ideas?
|
Since this is a regression and impacts a lot of use cases, I would like to see it fixed for 1.64 (but hopefully in master sooner). |
There is no regression here. Brandon's PR #8054 fixed this hidden point issue #8043 which is still fixed as of 1.63. It looks like you closed this issue #7557 (comment) without verifying that it was fixed by that PR. This most likely requires the same type of fix just applied in this distance display condition shader. |
My bad, I guess I didn't realize they were different issues. Sounds like we know how to fix it, so I'll leave this open as a next release issue. |
I've come across a strange issue that seems to only affects Linux. In the Sandcastle example, there are a bunch of points on the globe with distanceDisplayCondition configured. The points are configured to be visible only above 500000, and should be hidden below that.
On my Windows 10 PC with the same browser version, everything seems to work fine. On my CentOS PC though, there seems to be a single point visible in the center of the viewer after zooming past 500000. It's a bit hard to explain so I've attached some pictures below. Both PCs have Nvidia graphics cards (one is a 1060 and the other is a 980).
Before zooming past 500000:
After zooming past 500000 (on Windows):
After zooming past 500000 (on CentOS):
Sandcastle example: https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/#c=dVLva9swEP1XhL/UZpmcMApb6oZ1+TEGWxrmMfbBUBTrkorJUpDkpNno/96TXTu2xw5/uHv33jufpCMz5CjgBIbcEgUnMgcryoL+rLDwKq/KuVaOCQXmKrrJVM2nNgcFlMO23KeP+rQyrAC7AZNCrhVHO2dK8HQccdBCOYtYT3swohBOHMFSxnnYGb/x/E3TnmspIXdCqzCKGkfxBDIVfwBNJ4hlaqcNCX1LarUXruS+9XbyfnzTQRIyAN6gPCJ/M0UwLhbMtQ4fPL+pE9Ire2of9aLVOh207ljhVyDTZsk5Mw4zpt7RndHFAvYGwIbtv43aOdFo4NUuP73kA47NmYRP54Wwjqkcpt3bXQMzK2ZSpDATXo99jMg1fuPXfDIcyV990O8g2RlfBK/W6fku/kNqR6zLYovX/+3u10N6t1o+fFn/WH5efo8us579BVdJpp6DUZBYd5Ywq7GPojho40hpZEhp7KDAMXiG8bbMf4OjubVensSNKOHiSAS/zYLBQ84CkktmLXZ2pazOLwtmSYz8nkxqxoXa3x/B4EKe8jiZfa1BSmkSY/mvymktt8x0HF8A
Browser: Chrome 71.0.3578.98 (Official Build) (64-bit)
Operating System: CentOS 7.6.1810
The text was updated successfully, but these errors were encountered: