Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DistanceDisplayCondition point in the middle of the Viewer #7557

Closed
tangtony opened this issue Feb 11, 2019 · 9 comments · Fixed by #8542
Closed

DistanceDisplayCondition point in the middle of the Viewer #7557

tangtony opened this issue Feb 11, 2019 · 9 comments · Fixed by #8542

Comments

@tangtony
Copy link

I've come across a strange issue that seems to only affects Linux. In the Sandcastle example, there are a bunch of points on the globe with distanceDisplayCondition configured. The points are configured to be visible only above 500000, and should be hidden below that.

On my Windows 10 PC with the same browser version, everything seems to work fine. On my CentOS PC though, there seems to be a single point visible in the center of the viewer after zooming past 500000. It's a bit hard to explain so I've attached some pictures below. Both PCs have Nvidia graphics cards (one is a 1060 and the other is a 980).

Before zooming past 500000:
before

After zooming past 500000 (on Windows):
after windows

After zooming past 500000 (on CentOS):
after linux

Sandcastle example: https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/#c=dVLva9swEP1XhL/UZpmcMApb6oZ1+TEGWxrmMfbBUBTrkorJUpDkpNno/96TXTu2xw5/uHv33jufpCMz5CjgBIbcEgUnMgcryoL+rLDwKq/KuVaOCQXmKrrJVM2nNgcFlMO23KeP+rQyrAC7AZNCrhVHO2dK8HQccdBCOYtYT3swohBOHMFSxnnYGb/x/E3TnmspIXdCqzCKGkfxBDIVfwBNJ4hlaqcNCX1LarUXruS+9XbyfnzTQRIyAN6gPCJ/M0UwLhbMtQ4fPL+pE9Ire2of9aLVOh207ljhVyDTZsk5Mw4zpt7RndHFAvYGwIbtv43aOdFo4NUuP73kA47NmYRP54Wwjqkcpt3bXQMzK2ZSpDATXo99jMg1fuPXfDIcyV990O8g2RlfBK/W6fku/kNqR6zLYovX/+3u10N6t1o+fFn/WH5efo8us579BVdJpp6DUZBYd5Ywq7GPojho40hpZEhp7KDAMXiG8bbMf4OjubVensSNKOHiSAS/zYLBQ84CkktmLXZ2pazOLwtmSYz8nkxqxoXa3x/B4EKe8jiZfa1BSmkSY/mvymktt8x0HF8A

Browser: Chrome 71.0.3578.98 (Official Build) (64-bit)

Operating System: CentOS 7.6.1810

@hpinkos
Copy link
Contributor

hpinkos commented Feb 11, 2019

Thanks @tangtony! This sounds like it might be related to #7031

We've been having trouble reproducing this one which has made it tough to fix. Thank you so much for including the Sandcastle example! @mramato can you try that out on your linux machine?

@mramato
Copy link
Contributor

mramato commented Mar 11, 2019

I can absolutely reproduce this on Linux (Nvidia) and also via Cesium ion (the tileset position tool ends up with a large phantom point).

@tangtony
Copy link
Author

I forgot to mention this before, but I had messed around with this a few months ago and I had written down that v384.111 was the last Nvidia driver without this problem. I don't have a free machine to verify this again though.

@mramato
Copy link
Contributor

mramato commented Aug 16, 2019

Fixed via above PR

@mramato mramato closed this as completed Aug 16, 2019
@tangtony
Copy link
Author

tangtony commented Sep 19, 2019

The above PR does not fix this issue on my CentOS machine. Using the same Sandcastle example I can still reproduce the issue.

@mramato does the original Sandcastle example not exhibit any issues for you anymore?

@mramato
Copy link
Contributor

mramato commented Nov 6, 2019

Looks like this is indeed back. @OmarShehata didn't you fix an issue with how we hide points vs alpha or something recently with a shader? @lilleyse any ideas?

  1. Run http://localhost:8080/Apps/Sandcastle/index.html?src=Distance%20Display%20Conditions.html&label=All
  2. Switch to Point and Model and zoom in.
  3. Instead of the point switching off, it jumps to the center of the screen

image

@mramato
Copy link
Contributor

mramato commented Nov 6, 2019

Since this is a regression and impacts a lot of use cases, I would like to see it fixed for 1.64 (but hopefully in master sooner).

@OmarShehata
Copy link
Contributor

There is no regression here. Brandon's PR #8054 fixed this hidden point issue #8043 which is still fixed as of 1.63.

It looks like you closed this issue #7557 (comment) without verifying that it was fixed by that PR. This most likely requires the same type of fix just applied in this distance display condition shader.

@mramato
Copy link
Contributor

mramato commented Nov 7, 2019

My bad, I guess I didn't realize they were different issues. Sounds like we know how to fix it, so I'll leave this open as a next release issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants