Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rectangle no longer renders across IDL #6951

Closed
hpinkos opened this issue Aug 23, 2018 · 10 comments
Closed

Rectangle no longer renders across IDL #6951

hpinkos opened this issue Aug 23, 2018 · 10 comments

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Aug 23, 2018

This works in 1.45 but not in 1.46

var viewer = new Cesium.Viewer('cesiumContainer');

viewer.entities.add({
    rectangle: {
        coordinates: Cesium.Rectangle.fromDegrees(176.0, 30.0, -176.0, 40.0),
        material: Cesium.Color.RED,
        classificationType : Cesium.ClassificationType.TERRAIN
    }
});

viewer.zoomTo(viewer.entities);
@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 23, 2018

@likangning93 it looks like this was broken with your materials for ground primitives changes. Can you look into this soon?

@mramato
Copy link
Contributor

mramato commented Aug 23, 2018

It would be good to update one of our Sandcastle examples (rectangle entities?) so that the geometry just happens to span the IDL. This way when someone does release testing they should at least notice it.

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 23, 2018

I also thought we had a render test for this but maybe not

@likangning93 likangning93 self-assigned this Aug 23, 2018
@likangning93
Copy link
Contributor

Digging in a bit:

  • it's other primitives too
  • definitely related to the materials code since it works with other classification types
  • works for tiny areas in 3D b/c bounding planes instead of spherical extents
  • CV and 2D broken b/c the primitive gets split and the bounds don't apply anymore... so that's pretty annoying :(

@ggetz
Copy link
Contributor

ggetz commented Aug 31, 2018

@likangning93 Is 2D/Columbus view going to make it into this release? It should be merged today if so.

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 31, 2018

@ggetz #6967 fixed 3D. 2D/CV is still broken. I"m going to leave this issue marked next-release but I don't think we'll have a fix for 2D/CV in by today

@likangning93
Copy link
Contributor

@ggetz @hpinkos actually, PR for this should be open soon. Sorry for the radio silence!

@bagnell
Copy link
Contributor

bagnell commented Aug 31, 2018

Reopened because there is still an issue in 3D/CV. The volumes need to be closed.

@hpinkos
Copy link
Contributor Author

hpinkos commented Aug 31, 2018

@bagnell is that different than #4746?

@bagnell
Copy link
Contributor

bagnell commented Sep 4, 2018

Nope. Thanks, I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants