-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visible GroundPrimitive seam at IDL and Prime Meridian #4746
Comments
It's possible that the winding order for that wall of the shadow volume is flipped. |
Also seen with this GeoJSON file around the south pole ne_10m_admin_0_countries2.json.txt From https://groups.google.com/forum/?hl=en#!topic/cesium-dev/O_LaBx1_1wg |
From the forum: https://groups.google.com/forum/#!topic/cesium-dev/RH2GBImy2vI Seeing something similar with CorridorGeometries at the IDL and on the opposite side of the globe as well. Related? |
@ggetz yes, I think that's the same problem |
@bagnell thinks this is because the volumes for the underlying classification primitive gets split across the IDL, but the parts aren't closed independently. The artifact goes away when you manually "close" the volumes by spanning with two batched entities instead of just one, so figuring out how to close split volumes is probably the right fix. "Simulated" closed volumes and standard split volume compared on Sandcastle. I think this happens for giant geometry on the PM too because the IDL split is actually a split on the plane that contains both the PM and the IDL, and the check for whether the split needs to happen or not is based on bounding spheres or something. But that's a separate, less critical problem I think. |
Also reported by @HuZhuangQiang #4863 (comment) |
Also reported on the forum: https://community.cesium.com/t/strange-drawing-artifact-with-polygons-that-cross-dateline-bug/23749/3 |
It would be great if this bug could be fixed. Is anyone actively working on it? |
We don't have immediate plans to work on this item. But we'd be happy to accept a Pull Request for this feature if you have the time. Thanks! |
For
GroundPrimitives
, when the geometry is sufficiently large, there's a weird artifact atlongitude = 0
where we split into east and west hemispheres inGeometryPipeline.splitLongitudeTriangles
.(The same thing will happen across the IDL if you flip the east and west coordinates in the example below)
The text was updated successfully, but these errors were encountered: