Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firefox has ~48 camera-related test failures #6539

Closed
mramato opened this issue May 1, 2018 · 4 comments
Closed

Firefox has ~48 camera-related test failures #6539

mramato opened this issue May 1, 2018 · 4 comments
Labels
test failure

Comments

@mramato
Copy link
Contributor

mramato commented May 1, 2018

Cesium itself still works, so this seems to be a test-only problem with how we are doing epsilons. @bagnell says something like has happened before when Firefox released a new version. Our 1.44 tests fails now as well.

No need to hold up the release, but definitely look at for 1.46
@bagnell
Copy link
Contributor

bagnell commented May 1, 2018

I'm seeing those failures as far back as 1.39 (didn't test further).

@bagnell
Copy link
Contributor

bagnell commented May 31, 2018

Having FeatureDetection.supportsPointerEvents return false fixes most of the tests. It seems like the pointerdown event isn't fired.

@mramato
Copy link
Contributor Author

mramato commented Jun 1, 2018

It's possible that the regression confirmed in this bug is the cause: https://bugzilla.mozilla.org/show_bug.cgi?id=1463354

Basically the broke some part of pointerevents in FF 60. One solution is to not use PointerEvents on Firefox until it's fixed (basically change the FeatureDetection.supportsPointerEvents check to return false for Firefox.

Or we can just wait it out.

@mramato mramato mentioned this issue Jun 4, 2018
Merged
mramato added a commit that referenced this issue Aug 3, 2018
@mramato
Fix Firefox tests, add it to travis.yml
d769936 
1. Don't use PointerEvents for tests in Firefox, see #6539.  This makes
all tests but one pass.

2. Run built files against FirefhoxHeadless. This means we run unminified
on Chrome and minified on Firefox.  This helps keep the build time down
by not running everything twice on both browsers, but will still catch
Firefox-specific bugs that we can then run locally.
@mramato mramato mentioned this issue Aug 3, 2018
Merged
mramato added a commit that referenced this issue Aug 3, 2018
@mramato
Fix Firefox tests, add it to travis.yml
fff806f 
1. Don't use PointerEvents for tests in Firefox, see #6539.  This makes
all tests but one pass.

2. Run built files against FirefhoxHeadless. This means we run unminified
on Chrome and minified on Firefox.  This helps keep the build time down
by not running everything twice on both browsers, but will still catch
Firefox-specific bugs that we can then run locally.
mramato added a commit that referenced this issue Sep 1, 2018
@mramato
Disable PointerEvents in Firefox until they work.
e7d77b4 
We previously only disabled them in tests for #6539, but #6372 indicates
the problem may be more widespread.
@mramato mramato mentioned this issue Sep 3, 2018
Merged
@hpinkos
Copy link
Contributor

hpinkos commented Oct 1, 2018

Closing this issue. We disabled pointerevents in #6999 and that fixed the tests. Once we revert that change (#7003) we can double check to make sure tests are passing as expected.

@hpinkos hpinkos closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
test failure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bagnell @mramato @hpinkos