Some tiles not get loaded when switching terrainProvider

[Vineg]

If you change terrainProvider during reprojection of the tile, right after

            this.state = ImageryState.TRANSITIONING;
            this.imageryLayer._reprojectTexture(frameState, this, needGeographicProjection);

gets called, Imagery stucks in TRANSITIONING state and prevents tile from loading. It is happens because cancelReprojections gets called.

is method tileProvider.cancelReprojections affects something at all? Maybe we could remove it? If you comment it out, everything seems working fine.

In our application terrainProvider is changed early and it randomly causes one or two halves of the globe not loaded:

[mramato]

Thanks @Vineg, this definitely sounds like a bug. @bagnell any thoughts?

In our application terrainProvider is changed early

What do you mean by this? Are you setting the terrain provider right after creating the Viewer/Widget? If so, you can try passing the terrainProvider option into the widget constructor, which should workaround the issue for you.

[Vineg]

What do you mean by this? Are you setting the terrain provider right after creating the Viewer/Widget? If so, you can try passing the terrainProvider option into the widget constructor, which should workaround the issue for you.

@mramato, We load terrainProvider url with xhr and after it is loaded, we set it, so it is not immediatly after creating Widget, rather somewhat after it. I already workaround this issue by commenting out cancelReprojections in QuadtreePrimitive.prototype.invalidateAllTiles call.

[mramato]

OK, thanks. Is this easy to reproduce in a Sandcastle example? If you could share a simple test case that we can run ourselves that should make this much easier to fix. Thanks.

[Vineg]

@mramato here you go https://pastebin.com/na4cK7kR
It works not every time, run example few times.

[mramato]

Thanks @Vineg!

Here's the full example from the pastebin link:

var viewer = new Cesium.Viewer('cesiumContainer',{
});

// Load PA terrain
var cesiumTerrainProviderMeshes = new Cesium.CesiumTerrainProvider({
    url : 'https://assets.agi.com/stk-terrain/v1/tilesets/PAMAP/tiles',
    requestWaterMask : true,
    requestVertexNormals : true
});

var terrainProvider = new Cesium.CesiumTerrainProvider({
    url : 'https://assets.agi.com/stk-terrain/v1/tilesets/world/tiles'
});

setTimeout(function() {
    viewer.terrainProvider = terrainProvider;
    setTimeout(function() {
        viewer.terrainProvider = cesiumTerrainProviderMeshes;
        setTimeout(function() {
            viewer.terrainProvider = terrainProvider;
        },70);
    },550);
}, 2000);

[ggetz]

Brought up on the forum: https://groups.google.com/forum/#!topic/cesium-dev/4wKjJWPoLAk

[Vineg]

Here is quickfix geoscan@ce5c718 Maybe someone can review it?

[hpinkos]

@bagnell or @kring, can you take a look at this?

[kring]

I can still reproduce this with this Sandcastle.

[cesium-concierge]

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/4wKjJWPoLAk

If this issue affects any of these threads, please post a comment like the following:

The issue at #6021 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.