Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default icon is displayed when icon tag is empty #5819

Closed
josh-bernstein opened this issue Sep 7, 2017 · 3 comments
Closed

Default icon is displayed when icon tag is empty #5819

josh-bernstein opened this issue Sep 7, 2017 · 3 comments
Labels
category - kml type - bug

Comments

@josh-bernstein
Copy link
Contributor

I found a bug when I loaded a KML file containing the following
<IconStyle> <Icon></Icon> </IconStyle>

No icon is specified, and if I import that KML into Google Earth, the placemark icon is not shown. However, when I import the KML into an app using Cesium, a yellow placemark icon is shown.
@hpinkos
Copy link
Contributor

hpinkos commented Sep 7, 2017

Thanks for reporting this @josh-bernstein!

@josh-bernstein
Copy link
Contributor Author

@hpinkos My pleasure! I have a branch with a fix that I would like to push up, but I'm having GitHub difficultiies atm

@hpinkos
Copy link
Contributor

hpinkos commented Sep 7, 2017

Great, thanks @josh-bernstein! We're always happy to review pull requests. We have some details for opening a pull request in our contributing documentation here: https://github.com/AnalyticalGraphicsInc/cesium/blob/master/CONTRIBUTING.md#opening-a-pull-request

Hope you're able to figure out your GitHub issues without too much trouble. I'm not sure if this would help, but we have instructions for getting started and building the code base here: https://github.com/AnalyticalGraphicsInc/cesium/tree/master/Documentation/Contributors/BuildGuide#build-guide

josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 7, 2017
Fix bug where yellow icon is shown when icon tag is empty CesiumGS#5819
1fdc621
@josh-bernstein josh-bernstein mentioned this issue Sep 7, 2017
Merged
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 7, 2017
Revert "Fix bug where yellow icon is shown when icon tag is empty Ces…
b59cba1 
…iumGS#5819"

This reverts commit 1fdc621.
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 7, 2017
Fix bug with placemarks in imported KML, where placemarks with no spe…
13a6606 
…cified icon are displayed with yellow icon CesiumGS#5819
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 14, 2017
Add unit test and supporting KML file CesiumGS#5819
ab50ab5
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 14, 2017
Revert "Add unit test and supporting KML file CesiumGS#5819"
135d396 
This reverts commit ab50ab5.
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 14, 2017
Add KML file to be used in test CesiumGS#5819
8898faf
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 14, 2017
Add unit test for icon tag with no image CesiumGS#5819
515de90
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 14, 2017
Resolve merge conflict CesiumGS#5819
983ffa6
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Add my name to contributors file CesiumGS#5819
0bf2659
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Add test KML file with no style CesiumGS#5819
5518ba9
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Include company name in CONTRIBUTORS.md CesiumGS#5819
31efd9d
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Fix URL for company CesiumGS#5819
848e6af
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Fix case with no style tag, and add test CesiumGS#5819
b60dc73
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Add additional test CesiumGS#5819
90dbfd5
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Use === instead of == CesiumGS#5819
9ee14ae
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Sep 29, 2017
Remove extra space CesiumGS#5819
cd9c061
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 2, 2017
Add tag number to change in CHANGES.md CesiumGS#5819
6c40ecb
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 2, 2017
Pull and resolve merge conflict CesiumGS#5819
b0a3834
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 17, 2017
Cover edge case where IconStyle tag is empty CesiumGS#5819
470810d
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 17, 2017
Fix unit tests to use toEqual CesiumGS#5819
395dc5d
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 17, 2017
Update Changes.md to include change in next release CesiumGS#5819
5f5cb33
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 18, 2017
Revert "Cover edge case where IconStyle tag is empty CesiumGS#5819"
df09819 
This reverts commit 470810d.
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 20, 2017
Simplify code and cover all cases correctly CesiumGS#5819
cb773a6
josh-bernstein pushed a commit to josh-bernstein/cesium that referenced this issue Oct 23, 2017
Avoid using == CesiumGS#5819
4b0b03a
hpinkos pushed a commit that referenced this issue Oct 23, 2017
Merge pull request #5821 from josh-bernstein/5819_fix_for_empty_icon_tag
ae9be87 
Fix bug where yellow icon is shown when icon tag is empty #5819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
category - kml type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hpinkos @josh-bernstein