Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent GlobeSurfaceTile test failures on CI #4968

Closed
pjcozzi opened this issue Feb 9, 2017 · 11 comments
Closed

Intermittent GlobeSurfaceTile test failures on CI #4968

pjcozzi opened this issue Feb 9, 2017 · 11 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 9, 2017

@shehzan10 do you want to look at this at the bug bash?

These tests fail Intermittently. Perhaps there is a way to simplify them and make them more consistent.

  Scene/GlobeSurfaceTile
    processStateMachine
      ✗ upsampled terrainData is copied to the tile once it is available
	Error: Timeout - Async callback was not invoked within timeout specified by jasmine.DEFAULT_TIMEOUT_INTERVAL.
      ✗ loaded terrain data replaces upsampled terrain data
	Failed: promise rejected: TypeError: Cannot read property 'state' of undefined
	    at Specs/customizeJasmine.js:79:26
	    at Object.then (Source/ThirdParty/when.js:217:33)
	    at Source/ThirdParty/when.js:297:13
	    at processQueue (Source/ThirdParty/when.js:647:4)
@shehzan10
Copy link
Member

Sure.

@hpinkos
Copy link
Contributor

hpinkos commented Mar 7, 2017

@shehzan10 did you get a chance to look into this yet? This test failure keeps making greenkeeper throw up errors

@shehzan10
Copy link
Member

I did look into it around the February bug bash, but it was incredibly hard to reproduce as it was only happening intermittently. I don't really have any update on why this is happening because of that.

@mramato
Copy link
Contributor

mramato commented Mar 7, 2017

Does this test use external data? (If so that could certainly be part of the problem).

We should either fix this ASAP (preferred) or exclude the test in master (via xit) because it's making our unit tests too unstable.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Mar 7, 2017

I agree with @mramato. Given that we are focused elsewhere, perhaps just xit for now.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Mar 8, 2017

Ignored for now in #5085.

@mramato
Copy link
Contributor

mramato commented Mar 20, 2017

We are still receiving frequent travis failures because of the below two related tests. I would recommend we xit these as well, but there's a large problem here that we really need to look into sooner rather than later.

1) loaded terrain replacing upsampled terrain triggers re-upsampling and re-loading of children
     Scene/GlobeSurfaceTile processStateMachine
2) improved upsampled terrain triggers re-upsampling of children
     Scene/GlobeSurfaceTile processStateMachine

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Mar 20, 2017

Agreed. @rahwang do you want to make this small change: #4968 (comment)

@rahwang
Copy link
Contributor

rahwang commented Mar 21, 2017

Sure thing!

@hpinkos
Copy link
Contributor

hpinkos commented Mar 21, 2017

Those other two tests are now ignored #5135

@ggetz
Copy link
Contributor

ggetz commented Feb 21, 2022

The problematic tests have been removed at this point.

@ggetz ggetz closed this as completed Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants