Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScreenSpaceCameraController.minimumZoomDistance default is incorrect #4660

Closed
tfili opened this issue Nov 16, 2016 · 3 comments
Closed

ScreenSpaceCameraController.minimumZoomDistance default is incorrect #4660

tfili opened this issue Nov 16, 2016 · 3 comments
Labels
category - doc good first issue An opportunity for first time contributors

Comments

@tfili
Copy link
Contributor

tfili commented Nov 16, 2016

If you look at the code you'll see the actual default and the default in the doc are different. We should make them match.

I'm not sure what the correct value is. I've noticed that the value of 1.0 causes issues when you can zoom through terrain if you are zooming in to a mountain.

        /**
         * The minimum magnitude, in meters, of the camera position when zooming. Defaults to 20.0.
         * @type {Number}
         * @default 20.0
         */
        this.minimumZoomDistance = 1.0;
@pjcozzi pjcozzi added good first issue An opportunity for first time contributors category - doc labels Nov 18, 2016
@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 18, 2016

@bagnell do you know which is correct?

@bagnell
Copy link
Contributor

bagnell commented Nov 18, 2016

1.0 is correct. It used to be 20.0 to prevent the camera from clipping terrain in certain situations.

@mramato
Copy link
Contributor

mramato commented Nov 18, 2016

Unfortunately, @tfili found this because the camera is clipping terrain in certain situations 😈

pjcozzi added a commit that referenced this issue Dec 24, 2016
ScreenSpaceCameraController.maximumZoomDistance doc fixed #4660
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - doc good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

4 participants