Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SampledProperty.setInterpolationOptions does not properly ignore undefined #3575

Closed
shunter opened this issue Feb 15, 2016 · 1 comment
Closed
Labels
good first issue An opportunity for first time contributors type - bug

Comments

@shunter
Copy link
Contributor

shunter commented Feb 15, 2016

The implementation does not match the documentation. This makes it impossible to load CZML that relies on the documented defaults for algorithm / degree (LINEAR / 1)

failing test case:

var property = new Cesium.SampledProperty(Number);

var interpolationAlgorithm = property.interpolationAlgorithm;
var interpolationDegree = property.interpolationDegree;

property.setInterpolationOptions({});

expect(property.interpolationAlgorithm).toEqual(interpolationAlgorithm);
expect(property.interpolationDegree).toEqual(interpolationDegree);
@shunter
Copy link
Contributor Author

shunter commented Feb 15, 2016

Other issues in this class:

  • setInterpolationOptions should treat options as optional, as indicated in the doc for the function.
  • The example code incorrectly uses backticks for strings instead of single quotes.

@shunter shunter added the good first issue An opportunity for first time contributors label Jun 17, 2016
ottaviohartman added a commit to ottaviohartman/cesium that referenced this issue May 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue An opportunity for first time contributors type - bug
Projects
None yet
Development

No branches or pull requests

1 participant