Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal to deprecate EllipsoidPrimitive, RectanglePrimitive, and Polygon #3083

Closed
mramato opened this issue Oct 14, 2015 · 1 comment
Closed

Proposal to deprecate EllipsoidPrimitive, RectanglePrimitive, and Polygon #3083

mramato opened this issue Oct 14, 2015 · 1 comment
Labels
cleanup

Comments

@mramato
Copy link
Contributor

mramato commented Oct 14, 2015

I propose we deprecate (and remove in 3 releases) EllipsoidPrimitive, RectanglePrimitive, and PolygonPrimitive. These objects have outlived their usefulness and cause confusion for many users (adding yet a 3rd option in the API).

To jog everyone's memory,

EllipsoidPrimitive is the raycasted ellipsoid which only works in 3D and as far as I know no one uses. The EllipsoidGeometry and EllipsoidGraphics can handle everything it can do from an end-user's standpoing.

RectanglePrimitive and PolygonPrimitive both wrap their equivalent geometry. Thy have been superseded by the Entity API. And neither have been updated to keep base with underlying geometry features.

Any thoughts or objections?
@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 14, 2015

EllipsoidPrimitive

Let's mark this private since the moon uses it.

RectanglePrimitive and PolygonPrimitive

OK.

mramato added a commit that referenced this issue Oct 14, 2015
@mramato
Deprecate EllipsoidPrimitive, RectanglePrimitive, and Polygon
aa38a9d 
As discussed in #3083, these primitives are no longer needed and add
confusion to the public API.

I also replaced usage of them in any tests with the equivalent G&A code.
@mramato mramato mentioned this issue Oct 14, 2015
Merged
@mramato mramato changed the title Proposal to deprecate EllipsoidPrimitive, RectanglePrimitive, and PolygonPrimitive Proposal to deprecate EllipsoidPrimitive, RectanglePrimitive, and Polygon Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcozzi @mramato