Merge pull request #8955 from CesiumGS/wall-order

Draw walls with positions in order given

CHANGES.md

@@ -2,6 +2,10 @@
 
 ### 1.71 - 2020-07-01
 
+##### Breaking Changes :mega:
+
+- Updated `WallGeometry` to respect the order of positions passed in, instead of making the positions respect a counter clockwise winding order. This will only effect the look of walls with an image material. If this changed the way your wall is drawing, reverse the order of the positions.
+
 ##### Fixes :wrench:
 
 - Fixed error with `WallGeoemtry` when there were adjacent positions with very close values [#8952](https://github.com/CesiumGS/cesium/pull/8952)

Source/Core/WallGeometryLibrary.js

@@ -2,11 +2,8 @@ import arrayRemoveDuplicates from "./arrayRemoveDuplicates.js";
 import Cartesian3 from "./Cartesian3.js";
 import Cartographic from "./Cartographic.js";
 import defined from "./defined.js";
-import EllipsoidTangentPlane from "./EllipsoidTangentPlane.js";
 import CesiumMath from "./Math.js";
-import PolygonPipeline from "./PolygonPipeline.js";
 import PolylinePipeline from "./PolylinePipeline.js";
-import WindingOrder from "./WindingOrder.js";
 
 /**
  * @private
@@ -132,24 +129,6 @@ WallGeometryLibrary.computePositions = function (
   maximumHeights = o.topHeights;
   minimumHeights = o.bottomHeights;
 
-  if (wallPositions.length >= 3) {
-    // Order positions counter-clockwise
-    var tangentPlane = EllipsoidTangentPlane.fromPoints(
-      wallPositions,
-      ellipsoid
-    );
-    var positions2D = tangentPlane.projectPointsOntoPlane(wallPositions);
-
-    if (
-      PolygonPipeline.computeWindingOrder2D(positions2D) ===
-      WindingOrder.CLOCKWISE
-    ) {
-      wallPositions.reverse();
-      maximumHeights.reverse();
-      minimumHeights.reverse();
-    }
-  }
-
   var length = wallPositions.length;
   var numCorners = length - 2;
   var topPositions;