Merge pull request #11207 from CesiumGS/depthtestagainstterrain-default

Set depthTestAgainstTerrain when using the viewer with baseLayerPicker enabled
CesiumGS · Apr 3, 2023 · f29ab6f · f29ab6f
2 parents df6921e + 1e59b4c
commit f29ab6f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/engine/Source/Scene/DepthPlane.js b/packages/engine/Source/Scene/DepthPlane.js
@@ -125,7 +125,7 @@ DepthPlane.prototype.update = function (frameState) {
 
   const context = frameState.context;
 
-  // Allow offsetting the ellipsoid radius to address rendering artefacts below ellipsoid zero elevation.
+  // Allow offsetting the ellipsoid radius to address rendering artifacts below ellipsoid zero elevation.
   const radii = frameState.mapProjection.ellipsoid.radii;
   const ellipsoid = new Ellipsoid(
     radii.x + this._ellipsoidOffset,

diff --git a/packages/widgets/Source/Viewer/Viewer.js b/packages/widgets/Source/Viewer/Viewer.js
@@ -720,6 +720,8 @@ Either specify options.terrainProvider instead or set options.baseLayerPicker to
 
     if (createBaseLayerPicker) {
       baseLayerPicker.viewModel.selectedTerrain = undefined;
+      // Required as this is otherwise set by the baseLayerPicker
+      scene.globe.depthTestAgainstTerrain = true;
     }
 
     scene.setTerrain(options.terrain);