Skip to content

Commit

Permalink
Merge pull request #2776 from AnalyticalGraphicsInc/mighty-morphin-ra…
Browse files Browse the repository at this point in the history
…ce-conditions

Exception when using the camera inside morphComplete handler
  • Loading branch information
bagnell committed Jun 4, 2015
2 parents f1b3aab + 7a40d85 commit cdbe00a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
6 changes: 4 additions & 2 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ Change Log

### 1.11 - 2015-07-01

* Improved the algorithm that `Camera.viewRectangle` uses to select the position of the camera, so that the specified rectangle is now better centered on the screen.
* The performance statistics displayed by setting `scene.debugShowFramesPerSecond` to `true` can now be styled using the `cesium-performanceDisplay` CSS classes in `shared.css`.
* Improved the algorithm that `Camera.viewRectangle` uses to select the position of the camera, so that the specified rectangle is now better centered on the screen [#2764](https://github.com/AnalyticalGraphicsInc/cesium/issues/2764).
* The performance statistics displayed by setting `scene.debugShowFramesPerSecond` to `true` can now be styled using the `cesium-performanceDisplay` CSS classes in `shared.css` [#2779](https://github.com/AnalyticalGraphicsInc/cesium/issues/2779).
* Fixed a crash when `viewer.zoomTo` or `viewer.flyTo` were called immediately before or during a scene morph [#2775](https://github.com/AnalyticalGraphicsInc/cesium/issues/2775).
* Fixed an issue where `Camera` functions would throw an exception if used from within a `Scene.morphComplete` callback [#2776](https://github.com/AnalyticalGraphicsInc/cesium/issues/2776).

### 1.10 - 2015-06-01

Expand Down
3 changes: 3 additions & 0 deletions Source/Scene/SceneTransitioner.js
Original file line number Diff line number Diff line change
Expand Up @@ -656,6 +656,7 @@ define([

var wasMorphing = defined(transitioner._completeMorph);
transitioner._completeMorph = undefined;
scene.camera.update(scene.mode);
transitioner._scene.morphComplete.raiseEvent(transitioner, transitioner._previousMode, SceneMode.SCENE3D, wasMorphing);
}

Expand All @@ -678,6 +679,7 @@ define([

var wasMorphing = defined(transitioner._completeMorph);
transitioner._completeMorph = undefined;
scene.camera.update(scene.mode);
transitioner._scene.morphComplete.raiseEvent(transitioner, transitioner._previousMode, SceneMode.SCENE2D, wasMorphing);
}

Expand All @@ -703,6 +705,7 @@ define([

var wasMorphing = defined(transitioner._completeMorph);
transitioner._completeMorph = undefined;
scene.camera.update(scene.mode);
transitioner._scene.morphComplete.raiseEvent(transitioner, transitioner._previousMode, SceneMode.COLUMBUS_VIEW, wasMorphing);
}

Expand Down

0 comments on commit cdbe00a

Please sign in to comment.