Skip to content

Commit

Permalink
Upgrade gltf-pipeline and fix test
Browse files Browse the repository at this point in the history
  • Loading branch information
lilleyse committed Oct 30, 2018
1 parent cceb56c commit c6a5bd0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
3 changes: 2 additions & 1 deletion Source/ThirdParty/GltfPipeline/updateVersion.js
Original file line number Diff line number Diff line change
Expand Up @@ -853,7 +853,8 @@ define([
(!defined(node.translation) || Cartesian3.fromArray(node.translation).equals(Cartesian3.ZERO)) &&
(!defined(node.scale) || Cartesian3.fromArray(node.scale).equals(new Cartesian3(1.0, 1.0, 1.0))) &&
(!defined(node.rotation) || Cartesian4.fromArray(node.rotation).equals(new Cartesian4(0.0, 0.0, 0.0, 1.0))) &&
(!defined(node.matrix) || Matrix4.fromColumnMajorArray(node.matrix).equals(Matrix4.IDENTITY));
(!defined(node.matrix) || Matrix4.fromColumnMajorArray(node.matrix).equals(Matrix4.IDENTITY)) &&
!defined(node.extensions && !defined(node.extras));
}

function deleteNode(gltf, nodeId) {
Expand Down
2 changes: 1 addition & 1 deletion Specs/Scene/ModelSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -2080,7 +2080,7 @@ defineSuite([
expect(scene).toRender([0, 0, 0, 255]);
m.show = true;
m.zoomTo();
expect(scene).toRender([51, 51, 51, 255]); // Cesium has minimum lighting
expect(scene).toRender([0, 0, 0, 255]);
m.show = false;

primitives.remove(m);
Expand Down

0 comments on commit c6a5bd0

Please sign in to comment.