Skip to content

Commit

Permalink
Fix lint errors and add myself to CONTRIBUTORS
Browse files Browse the repository at this point in the history
  • Loading branch information
markerikson committed Apr 17, 2018
1 parent 6b08f9c commit a3d525d
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
Original file line number Diff line number Diff line change
Expand Up @@ -177,3 +177,4 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
* [Tamar Cohen](https://github.com/tamarmot)
* [Stephen Wiseman](https://github.com/srwiseman)
* [Gabriel Macario](https://github.com/gabriel-macario)
* [Mark Erikson](https://github.com/markerikson)
4 changes: 2 additions & 2 deletions Source/Scene/PolylineCollection.js
Original file line number Diff line number Diff line change
Expand Up @@ -299,12 +299,12 @@ define([
PolylineCollection.prototype.remove = function(polyline) {
if (this.contains(polyline)) {
this._polylines[polyline._index] = undefined; // Removed later

var polylineUpdateIndex = this._polylinesToUpdate.indexOf(polyline);
if(this._polylinesToUpdate.length && polylineUpdateIndex >= 0) {
this._polylinesToUpdate.splice(polylineUpdateIndex, 1);
}

this._polylinesRemoved = true;
this._createVertexArray = true;
this._createBatchTable = true;
Expand Down
3 changes: 1 addition & 2 deletions Specs/Scene/PolylineCollectionSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ defineSuite([
polylines.removeAll();
expect(polylines.length).toEqual(0);
});

it('removes a polyline from the updated list when removed', function() {
var firstPolyline = polylines.add();
var secondPolyline = polylines.add();
Expand All @@ -343,7 +343,6 @@ defineSuite([
expect(polylines._polylinesToUpdate.length).toEqual(1);
});


it('can check if it contains a polyline', function() {
var polyline = polylines.add();

Expand Down

0 comments on commit a3d525d

Please sign in to comment.