Skip to content

Commit

Permalink
Remove redundant checks in *Frustum comparison methods
Browse files Browse the repository at this point in the history
  • Loading branch information
lukesanantonio committed Jul 26, 2018
1 parent f626f31 commit a041bbf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 8 deletions.
4 changes: 0 additions & 4 deletions Source/Core/OrthographicFrustum.js
Original file line number Diff line number Diff line change
Expand Up @@ -270,8 +270,6 @@ define([

return (this.width === other.width &&
this.aspectRatio === other.aspectRatio &&
this.near === other.near &&
this.far === other.far &&
this._offCenterFrustum.equals(other._offCenterFrustum));
};

Expand All @@ -295,8 +293,6 @@ define([

return (CesiumMath.equalsEpsilon(this.width, other.width, relativeEpsilon, absoluteEpsilon) &&
CesiumMath.equalsEpsilon(this.aspectRatio, other.aspectRatio, relativeEpsilon, absoluteEpsilon) &&
CesiumMath.equalsEpsilon(this.near, other.near, relativeEpsilon, absoluteEpsilon) &&
CesiumMath.equalsEpsilon(this.far, other.far, relativeEpsilon, absoluteEpsilon) &&
this._offCenterFrustum.equalsEpsilon(other._offCenterFrustum, relativeEpsilon, absoluteEpsilon));
};

Expand Down
4 changes: 0 additions & 4 deletions Source/Core/PerspectiveFrustum.js
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,6 @@ define([

return (this.fov === other.fov &&
this.aspectRatio === other.aspectRatio &&
this.near === other.near &&
this.far === other.far &&
this._offCenterFrustum.equals(other._offCenterFrustum));
};

Expand All @@ -390,8 +388,6 @@ define([

return (CesiumMath.equalsEpsilon(this.fov, other.fov, relativeEpsilon, absoluteEpsilon) &&
CesiumMath.equalsEpsilon(this.aspectRatio, other.aspectRatio, relativeEpsilon, absoluteEpsilon) &&
CesiumMath.equalsEpsilon(this.near, other.near, relativeEpsilon, absoluteEpsilon) &&
CesiumMath.equalsEpsilon(this.far, other.far, relativeEpsilon, absoluteEpsilon) &&
this._offCenterFrustum.equalsEpsilon(other._offCenterFrustum, relativeEpsilon, absoluteEpsilon));
};

Expand Down

0 comments on commit a041bbf

Please sign in to comment.