Skip to content

Commit

Permalink
Always outline walls so they show up in 2D
Browse files Browse the repository at this point in the history
  • Loading branch information
mramato committed Feb 12, 2017
1 parent c9a6e51 commit 94412f9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Change Log
### 1.31 - 2017-03-01
* Added support to `DebugCameraPrimitive` to draw multifrustum planes. The attribute `debugShowFrustumPlanes` of `Scene` and `frustumPlanes` of `CesiumInspector` toggles this. `FrameState` has been augmented to include `frustumSplits` which is a `Number[]` of the near/far planes of the camera frustums.
* Enable rendering `GroundPrimitives` on hardware without the `EXT_frag_depth` extension; however, this could cause artifacts for certain viewing angles.
* Always outline KML line extrusions so that they show up properly in 2D and other straight down views.
* Added compressed texture support. [#4758](https://github.com/AnalyticalGraphicsInc/cesium/pull/4758)
* glTF models and imagery layers can now reference [KTX](https://www.khronos.org/opengles/sdk/tools/KTX/) textures and textures compressed with [crunch](https://github.com/BinomialLLC/crunch).
* Added `loadKTX`, to load KTX textures, and `loadCRN` to load crunch compressed textures.
Expand Down
6 changes: 4 additions & 2 deletions Source/DataSources/KmlDataSource.js
Original file line number Diff line number Diff line change
Expand Up @@ -1156,14 +1156,16 @@ define([

if (defined(polygon)) {
wall.fill = polygon.fill;
wall.outline = polygon.outline;
wall.material = polygon.material;
}

//Always outline walls so they show up in 2D.
wall.outline = true;
if (defined(polyline)) {
wall.outline = true;
wall.outlineColor = defined(polyline.material) ? polyline.material.color : Color.WHITE;
wall.outlineWidth = polyline.width;
} else if (defined(polygon)) {
wall.outlineColor = defined(polygon.material) ? polygon.material.color : Color.WHITE;
}
} else {
if (dataSource._clampToGround && !canExtrude && tessellate) {
Expand Down

0 comments on commit 94412f9

Please sign in to comment.