Skip to content

Commit

Permalink
Typo/format fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
shehzan10 committed Jan 12, 2017
1 parent 0da8235 commit 89756c1
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 10 deletions.
4 changes: 2 additions & 2 deletions Source/Core/EllipseGeometry.js
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ define([
bitangents[i1] = bitangent.y;
bitangents[i2] = bitangent.z;
if (extrude) {
bitangents[i + bottomOffset] = bitangent.x;
bitangents[i + bottomOffset] = bitangent.x;
bitangents[i1 + bottomOffset] = bitangent.y;
bitangents[i2 + bottomOffset] = bitangent.z;
}
Expand Down Expand Up @@ -501,7 +501,7 @@ define([
bitangents[i1] = bitangent.y;
bitangents[i2] = bitangent.z;

bitangents[i + length] = bitangent.x;
bitangents[i + length] = bitangent.x;
bitangents[i1 + length] = bitangent.y;
bitangents[i2 + length] = bitangent.z;
}
Expand Down
6 changes: 3 additions & 3 deletions Source/Core/PolygonGeometry.js
Original file line number Diff line number Diff line change
Expand Up @@ -303,17 +303,17 @@ define([

if (vertexFormat.bitangent) {
if (bottom) {
bitangents[attrIndex + bottomOffset] = bitangent.x;
bitangents[attrIndex + bottomOffset] = bitangent.x;
bitangents[attrIndex1 + bottomOffset] = bitangent.y;
bitangents[attrIndex2 + bottomOffset] = bitangent.z;
}
if (top) {
if (perPositionHeight) {
bitangents[attrIndex ] = scratchPerPosBitangent.x;
bitangents[attrIndex] = scratchPerPosBitangent.x;
bitangents[attrIndex1] = scratchPerPosBitangent.y;
bitangents[attrIndex2] = scratchPerPosBitangent.z;
} else {
bitangents[attrIndex ] = bitangent.x;
bitangents[attrIndex] = bitangent.x;
bitangents[attrIndex1] = bitangent.y;
bitangents[attrIndex2] = bitangent.z;
}
Expand Down
6 changes: 3 additions & 3 deletions Source/Core/RectangleGeometry.js
Original file line number Diff line number Diff line change
Expand Up @@ -126,17 +126,17 @@ define([
}

if (vertexFormat.normal) {
normals[attrIndex ] = normal.x;
normals[attrIndex] = normal.x;
normals[attrIndex1] = normal.y;
normals[attrIndex2] = normal.z;
}
if (vertexFormat.tangent) {
tangents[attrIndex ] = tangent.x;
tangents[attrIndex] = tangent.x;
tangents[attrIndex1] = tangent.y;
tangents[attrIndex2] = tangent.z;
}
if (vertexFormat.bitangent) {
bitangents[attrIndex ] = bitangent.x;
bitangents[attrIndex] = bitangent.x;
bitangents[attrIndex1] = bitangent.y;
bitangents[attrIndex2] = bitangent.z;
}
Expand Down
4 changes: 2 additions & 2 deletions Specs/Core/GeometryPipelineSpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -1632,7 +1632,7 @@ defineSuite([
-0.4082482904638631, -0.8164965809277261, 0.4082482904638631], CesiumMath.EPSILON7);
});

it ('computeTangentAndBitangent computes tangent and bitangent for an BoxGeometry', function() {
it ('computeTangentAndBitangent computes tangent and bitangent for BoxGeometry', function() {
var geometry = BoxGeometry.createGeometry(new BoxGeometry({
vertexFormat : new VertexFormat({
position : true,
Expand Down Expand Up @@ -1668,7 +1668,7 @@ defineSuite([
}
});

it ('computeBinormalAndTangent computes tangent and binormal for an BoxGeometry', function() {
it ('computeBinormalAndTangent computes tangent and binormal for BoxGeometry', function() {
// This test is for the deprecated computeBinormalAndTangent API
// It tests to assert that the binormal attribute is set correctly and
// is a copy of the bitangent attribute
Expand Down

0 comments on commit 89756c1

Please sign in to comment.