Skip to content

Commit

Permalink
Fix Entity id type in EntityCollection
Browse files Browse the repository at this point in the history
The Entity id type is String.
  • Loading branch information
gberaudo committed Aug 31, 2017
1 parent 2f7421b commit 5c6feee
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Source/DataSources/EntityCollection.js
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,7 @@ define([
/**
* Removes an entity with the provided id from the collection.
*
* @param {Object} id The id of the entity to remove.
* @param {String} id The id of the entity to remove.
* @returns {Boolean} true if the item was removed, false if no item with the provided id existed in the collection.
*/
EntityCollection.prototype.removeById = function(id) {
Expand Down Expand Up @@ -382,7 +382,7 @@ define([
/**
* Gets an entity with the specified id.
*
* @param {Object} id The id of the entity to retrieve.
* @param {String} id The id of the entity to retrieve.
* @returns {Entity} The entity with the provided id or undefined if the id did not exist in the collection.
*/
EntityCollection.prototype.getById = function(id) {
Expand All @@ -398,7 +398,7 @@ define([
/**
* Gets an entity with the specified id or creates it and adds it to the collection if it does not exist.
*
* @param {Object} id The id of the entity to retrieve or create.
* @param {String} id The id of the entity to retrieve or create.
* @returns {Entity} The new or existing object.
*/
EntityCollection.prototype.getOrCreateEntity = function(id) {
Expand Down

0 comments on commit 5c6feee

Please sign in to comment.