Minor tweak, update CHANGES.

CesiumGS · Apr 28, 2020 · 3ed3565 · 3ed3565
1 parent 1fe709b
commit 3ed3565
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -19,6 +19,7 @@
 - Fixed an issue with clamping of non-looped glTF animations. Subscribers to animation `update` events should expect one additional event firing as an animation stops. [#7387](https://github.com/CesiumGS/cesium/issues/7387)
 - Fixed a bug with very long view ranges requiring multiple frustums even with the logarithmic depth buffer enabled. Previously, such scenes could resolve depth incorrectly. [#8727](https://github.com/CesiumGS/cesium/pull/8727)
 - Fixed a bug where the elevation contour material's alpha was not being applied. [#8749](https://github.com/CesiumGS/cesium/pull/8749)
+- Fix potential memory leak when destroying `CesiumWidget` instances.
 
 ### 1.68.0 - 2020-04-01
 

diff --git a/Source/Widgets/CesiumWidget/CesiumWidget.js b/Source/Widgets/CesiumWidget/CesiumWidget.js
@@ -710,10 +710,10 @@ CesiumWidget.prototype.isDestroyed = function () {
  * removing the widget from layout.
  */
 CesiumWidget.prototype.destroy = function () {
-  if (this._scene) {
+  if (defined(this._scene)) {
     this._scene.renderError.removeEventListener(this._onRenderError);
+    this._scene = this._scene.destroy();
   }
-  this._scene = this._scene && this._scene.destroy();
   this._container.removeChild(this._element);
   this._creditContainer.removeChild(this._innerCreditContainer);
   destroyObject(this);