Skip to content

Commit

Permalink
Updates from review
Browse files Browse the repository at this point in the history
  • Loading branch information
lilleyse committed May 22, 2020
1 parent f755ea6 commit 3c9af3e
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions Source/Scene/SkyAtmosphere.js
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ SkyAtmosphere.prototype.setDynamicAtmosphereColor = function (
this._radiiAndDynamicAtmosphereColorAndInverseScale.z = lightEnum;
};

var scratchRotationMatrix = new Matrix3();
var scratchModelMatrix = new Matrix4();

/**
Expand All @@ -189,10 +188,8 @@ SkyAtmosphere.prototype.update = function (frameState) {

// Align the ellipsoid geometry so it always faces the same direction as the
// camera to reduce artifacts when rendering atmosphere per-vertex
var view = frameState.context.uniformState.viewRotation;
var inverseView = Matrix3.inverse(view, scratchRotationMatrix);
var rotationMatrix = Matrix4.fromRotationTranslation(
inverseView,
frameState.context.uniformState.inverseViewRotation,
Cartesian3.ZERO,
scratchModelMatrix
);
Expand Down

0 comments on commit 3c9af3e

Please sign in to comment.