Update cesium-native to latest #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kring Looks like all the build issues have been fixed. Windows build on CI failed due to the same transient error I was getting on the last PR - seems like the CI machine might be running out of memory? It went away last time when we ran CI again, so hopefully it will go away again this time. |
|
This build is failing because the UWP x86-64 native build is failing. Looking at the build logs (they're published as a build artifact), the error is this: So that should be an easy fix. I'll do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an oversight we made with #518, the cesium-native branch wasn't switched back to main after the shared asset changes were merged into main. This shouldn't cause any issues, but wanted to make it a PR so CI could run its checks.