Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cesium-native branch of CesiumGS/glTF as the code gen source. #1020

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

kring
Copy link
Member

@kring kring commented Dec 3, 2024

The code generation for the glTF classes was previously pulling its schemas from:
https://github.com/CesiumGS/glTF/tree/3d-tiles-next

With this PR, it's pulling them from:
https://github.com/CesiumGS/glTF/tree/cesium-native

The two branches are currently identical, so this doesn't change much to start. But the idea is that it:

  1. Gives us an official source for the glTF spec used by cesium-native,
  2. Allows us to incorporate extensions that are not yet ratified or even officially blessed as part of 3D Tiles,
  3. Insulates the cesium-native codegen from surprising upstream changes (we take changes when we mean to, not necessarily every time we re-rerun the code generator).

We should do PRs into https://github.com/CesiumGS/glTF/tree/cesium-native when we want to bring in upstream changes or incorporate new extensions.

CC @weegeekps @keyboardspecialist @lilleyse

@lilleyse lilleyse merged commit 624f5b2 into main Dec 3, 2024
22 checks passed
@lilleyse lilleyse deleted the gltf-generation-source branch December 3, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants