Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Trim words in corporate CLA check #140

Merged
merged 1 commit into from
Aug 16, 2019
Merged

Trim words in corporate CLA check #140

merged 1 commit into from
Aug 16, 2019

Conversation

OmarShehata
Copy link
Contributor

@OmarShehata OmarShehata commented Aug 16, 2019

Concierge failed to look up a CLA that we know was in a corporate Schedule A (CesiumGS/cesium#8076 (comment)). This was because the block of text returned from the Google Sheets API has extra control characters at the end that need to be trimmed before doing a string comparison.

Tested this by running concierge locally with the corporate CLA spreadsheet to confirm it now correctly detects it.

There was also a typo in that it was setting foundIndividualCLA regardless of whether it was the corporate or individual, but that doesn't change the returned result either way.

@cesium-concierge
Copy link

Thanks for the pull request @OmarShehata!

  • ❌ Missing CLA.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

✨ ✨ ✨I'm the Cesium Concierge and I'm here to test things. ✨ ✨ ✨

@emackey
Copy link

emackey commented Aug 16, 2019

This comment from Concierge is probably the most ironic one yet posted here.

@OmarShehata
Copy link
Contributor Author

Merging and deploying since I've already tested this.

@OmarShehata OmarShehata merged commit 2ef36f3 into master Aug 16, 2019
@OmarShehata OmarShehata deleted the cla-fix branch August 16, 2019 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants