-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
Thanks for the pull request @OmarShehata!
✨ ✨ ✨I'm the Cesium Concierge and I'm here to test things. ✨ ✨ ✨ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OmarShehata! Also make sure to update the templates in the relevant repositories once this is deployed.
Thanks for the super speed review @ggetz ! And you were right, it's a lot simpler just listing outreach users in the template itself as opposed to adding a config. I added a test to make sure it doesn't post if a user is not a first time contributor, fixed that missing period in the template, and added a TODO bullet point in this PR to remember to update the templates in the relevant repositories. |
This is good to go. Let's check #126 works before deploying this change as well. And, of course, update the relevant repos when you deploy as well! |
Thanks again for your contribution @OmarShehata! No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy? I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with ✨ ✨ ✨I'm the Cesium Concierge and I'm here to test things. ✨ ✨ ✨ |
Once deployed, this should start working right away, since the Cesium repo uses the default issueClosedTemplate which will tag me and Sarah. We can change that here or in the Cesium repo if we want to change who to tag. |
This implements the feature described here #85.
I branched off of #118 because I needed the contributors URL fix from there. This just checks the
CONTRIBUTORS.md
in the repo/branch you're merging into. If the user's name isn't there, they are declared to be a first time external contributor and concierge will @ mention outreach team members. I didn't bother differentiating between internal/external contributors because if it's someone's first contribution they are 99% probably an external contributor.To do when merged: