Add point cloud styling section #138

lilleyse · 2016-10-21T14:36:55Z

Added pointSize, ${POSITION}, ${COLOR}, ${NORMAL}

@pjcozzi I'm in the process of writing a section for shader styling. Did we decide on a final solution for the current GLSL styling limitations? I have the current issues in CesiumGS/cesium#3241 under the Point Cloud Shader Styling section:

Point Cloud Shader Styling

Unsupported:

isNan, isFinite(supported in later versions of GLSL with isnan and isinf)

Strings, not supported in the GLSL styling engine or the batch table binary

Regular expressions

Arrays that aren't length 2, 3, or 4.

null and undefined - use a default value like 0?

type mismatching - comparing floats to bools to vecn will result in shader compilation errors

and some notes here: CesiumGS/cesium#4336 (comment)

I am also going to write a section for the new ColorBlendMode types in CesiumGS/cesium#4451. Technically this is not part of the declarative styling language though, so should it go in the Styling section or the main README ?

pjcozzi · 2016-10-21T14:55:43Z

Did we decide on a final solution for the current GLSL styling limitations?

No. The plan is to continue to work on the implementation and see how impactful these limitations are, then we will be in a better position to decide.

Can you submit an issue to this repo labeled "Draft 1.0" with the above info and then link to it from the Cesium roadmap issue?

pjcozzi · 2016-10-21T14:57:46Z

Technically this is not part of the declarative styling language though, so should it go in the Styling section or the main README ?

The spec is about the spec, not the Cesium implementation. I think the spec should say that the computed color from the style can be applied in an application-specific way, e.g., replace, modulate, mix. We just have to carefully word so that a valid implementation can't just set the color to black and say it conforms.

pjcozzi · 2016-10-21T14:59:38Z

Styling/README.md

@@ -469,6 +470,37 @@ ${temperatures.values[0]} === 70
 ${temperatures['values'][0]} === 70 // Same as (temperatures[values])[0] and temperatures.values[0]
 ```

+### Point Cloud
+
+In addition to evaluating a point's `color` and `show` properties, a point cloud style may evaluate `pointSize`, or the size of each point in pixels. The default `pointSize` is `1.0`.


Be more explicit here about what a point cloud is; mention the title type and link to it.

pjcozzi · 2016-10-21T15:00:34Z

Styling/README.md

+}
+```
+
+Implementations may clamp the evaluated `pointSize` to the system's supported point size range. For example, WebGL renderers may query `ALIASED_POINT_SIZE_RANGE` to get the system limits when rendering with `POINTS`.


Perhaps say that a pointSize of 1.0 must be supported.

pjcozzi · 2016-10-21T15:01:47Z

Styling/README.md

+Implementations may clamp the evaluated `pointSize` to the system's supported point size range. For example, WebGL renderers may query `ALIASED_POINT_SIZE_RANGE` to get the system limits when rendering with `POINTS`.
+
+Point cloud styles may also reference per-point semantics including position, color, and normal to allow for more flexible styling of the source data.
+* `${POSITION}` is an array of three values representing the xyz coordinates of the point before the `RTC_CENTER` and tile transform are applied. When the positions are quantized, `${POSITION}` refers to the position after the `QUANTIZED_VOLUME_SCALE` is applied, but before `QUANTIZED_VOLUME_OFFSET` is applied.


Precisely say what coordinate system that is using the same terms in the point cloud spec.

Also precisely say the type of each component, e.g., float.

pjcozzi · 2016-10-21T15:02:41Z

Styling/README.md

+
+Point cloud styles may also reference per-point semantics including position, color, and normal to allow for more flexible styling of the source data.
+* `${POSITION}` is an array of three values representing the xyz coordinates of the point before the `RTC_CENTER` and tile transform are applied. When the positions are quantized, `${POSITION}` refers to the position after the `QUANTIZED_VOLUME_SCALE` is applied, but before `QUANTIZED_VOLUME_OFFSET` is applied.
+* `${COLOR}` evaluates to a Color type, where each of the rgba color components are in the range `0.0` to `1.0`.


Precisely state component type.

pjcozzi · 2016-10-21T15:02:53Z

Styling/README.md

+Point cloud styles may also reference per-point semantics including position, color, and normal to allow for more flexible styling of the source data.
+* `${POSITION}` is an array of three values representing the xyz coordinates of the point before the `RTC_CENTER` and tile transform are applied. When the positions are quantized, `${POSITION}` refers to the position after the `QUANTIZED_VOLUME_SCALE` is applied, but before `QUANTIZED_VOLUME_OFFSET` is applied.
+* `${COLOR}` evaluates to a Color type, where each of the rgba color components are in the range `0.0` to `1.0`.
+* `${NORMAL}` is an array of three values representing the normal of the point before the tile transform is applied. When normals are oct-encoded `${NORMAL}` refers to the decoded normal.


Precisely state coordinate system and component type.

pjcozzi · 2016-10-21T15:03:40Z

Styling/README.md

+
+Implementations may clamp the evaluated `pointSize` to the system's supported point size range. For example, WebGL renderers may query `ALIASED_POINT_SIZE_RANGE` to get the system limits when rendering with `POINTS`.
+
+Point cloud styles may also reference per-point semantics including position, color, and normal to allow for more flexible styling of the source data.


"semantics from the Feature Table"

pjcozzi · 2016-10-21T15:04:55Z

Styling/README.md

+```json
+{
+    "color" : "${COLOR} * color('red')'",
+    "show" : "${POSITION}[0] > 0.5",


Should these be arrays or .xyz and .rgba? I get that the later is more work since we have to introduce a vec3 type to the styling language, but it is more natural.

Yeah vec3/vec4 is more natural and is how a styling shader would implements it, as well as makes more sense in terms of math operations.

pjcozzi · 2016-11-23T13:51:26Z

Bump. @lilleyse let's not forget about this one.

lilleyse · 2017-01-09T19:54:35Z

Updated with reference to #166

pjcozzi · 2017-01-10T01:05:16Z

@lilleyse what else is need here after #166?

lilleyse · 2017-01-10T01:34:15Z

That should be it, unless you see any areas to change.

lilleyse · 2017-01-10T01:34:59Z

The Point Cloud Shader Styling section is still a TODO because we haven't fully fleshed out the rules for typechecking and other things.

pjcozzi · 2017-01-10T17:51:20Z

The Point Cloud Shader Styling section is still a TODO because we haven't fully fleshed out the rules for typechecking and other things.

Please submit an issue for this labeled 1.0 and styling by flushing out the tasklist and Cesium PR linked to at the top here.

In the meantime, it is OK to merge this with the TODO.

lilleyse · 2017-01-10T18:02:47Z

This issue should have all the current GLSL limitations: #140

Add point cloud styling section

87fceaa

pjcozzi added the styling label Oct 21, 2016

Swap names

6f09dc9

pjcozzi reviewed Oct 21, 2016

View reviewed changes

lilleyse mentioned this pull request Dec 15, 2016

3D Tiles - Support vectors in the styling language CesiumGS/cesium#4759

Merged

2 tasks

lilleyse mentioned this pull request Jan 9, 2017

Vector types: vec2, vec3, vec4 #166

Merged

1 task

lilleyse changed the base branch from master to vector January 9, 2017 18:49

lilleyse changed the base branch from vector to master January 9, 2017 18:51

Vector updates

918fbba

lilleyse force-pushed the pnts-styling branch from 5e5ebba to 918fbba Compare January 9, 2017 19:53

pjcozzi merged commit 434bd71 into master Jan 10, 2017

pjcozzi deleted the pnts-styling branch January 10, 2017 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add point cloud styling section #138

Add point cloud styling section #138

lilleyse commented Oct 21, 2016 •

edited

Loading

pjcozzi commented Oct 21, 2016

pjcozzi commented Oct 21, 2016

pjcozzi Oct 21, 2016

pjcozzi Oct 21, 2016

pjcozzi Oct 21, 2016

pjcozzi Oct 21, 2016

pjcozzi Oct 21, 2016

pjcozzi Oct 21, 2016

pjcozzi Oct 21, 2016

pjcozzi Oct 21, 2016

lilleyse Oct 21, 2016

pjcozzi commented Nov 23, 2016

lilleyse commented Jan 9, 2017

pjcozzi commented Jan 10, 2017

lilleyse commented Jan 10, 2017

lilleyse commented Jan 10, 2017

pjcozzi commented Jan 10, 2017

lilleyse commented Jan 10, 2017


		Implementations may clamp the evaluated `pointSize` to the system's supported point size range. For example, WebGL renderers may query `ALIASED_POINT_SIZE_RANGE` to get the system limits when rendering with `POINTS`.

		Point cloud styles may also reference per-point semantics including position, color, and normal to allow for more flexible styling of the source data.

Add point cloud styling section #138

Add point cloud styling section #138

Conversation

lilleyse commented Oct 21, 2016 • edited Loading

pjcozzi commented Oct 21, 2016

pjcozzi commented Oct 21, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Nov 23, 2016

lilleyse commented Jan 9, 2017

pjcozzi commented Jan 10, 2017

lilleyse commented Jan 10, 2017

lilleyse commented Jan 10, 2017

pjcozzi commented Jan 10, 2017

lilleyse commented Jan 10, 2017

lilleyse commented Oct 21, 2016 •

edited

Loading