-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pnts update #116
Merged
Merged
Pnts update #116
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
fd8074a
Initial draft for points
lilleyse b838ac7
Updated with examples
lilleyse ca865e4
Update status
pjcozzi 9032d81
Tweak
pjcozzi 87d6144
Tweaks
pjcozzi 8adb52e
Wording updates
lilleyse 9b7171c
Merge branch 'master' into pnts-updates
lilleyse 2272d6c
Forgot to save file
lilleyse c930778
Another small merge fix
lilleyse 986c5a9
Comma
lilleyse 27bad0a
Tweaks
pjcozzi 5ad6bce
Added quantized figure and added example
lilleyse 24bf813
Fix number
lilleyse f4771f9
Revert quantized volume change
lilleyse e54ad5c
Update folder name from Points to PointCloud
lilleyse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -169,7 +169,7 @@ var featureTableBinary = new Buffer(new Float32Array([ | |
#### Quantized Positions and Oct-Encoded Normals | ||
|
||
In this example, the 4 instances will be placed with an orientation `up` of `[0.0, 1.0, 0.0]` and `right` of `[1.0, 0.0, 0.0]` in oct-encoded format | ||
and they will be placed on the corners of a quantized volume that spans from `-250.0` to `250.0` units in the `x` and `z` directions. | ||
and they will be placed on the corners of a quantized volume that spans from `-500.0` to `0.0` units in the `x` and `z` directions. | ||
|
||
```javascript | ||
var featureTableJSON = { | ||
|
@@ -187,21 +187,21 @@ var featureTableJSON = { | |
} | ||
}; | ||
|
||
var positionQuantizedBinary = new Buffer(new UInt16Array([ | ||
var positionQuantizedBinary = new Buffer(new Uint16Array([ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for catching this! |
||
0, 0, 0, | ||
65535, 0, 0, | ||
0, 0, 65535, | ||
65535, 0, 65535 | ||
]).buffer); | ||
|
||
var normalUpOct32PBinary = new Buffer(new UInt16Array([ | ||
var normalUpOct32PBinary = new Buffer(new Uint16Array([ | ||
32768, 65535, | ||
32768, 65535, | ||
32768, 65535, | ||
32768, 65535 | ||
]).buffer); | ||
|
||
var normalRightOct32PBinary = new Buffer(new UInt16Array([ | ||
var normalRightOct32PBinary = new Buffer(new Uint16Array([ | ||
65535, 32768, | ||
65535, 32768, | ||
65535, 32768, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure if these numbers were supposed to also take the offset into account, so I adjusted them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lasalvavida can you confirm this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this change is not correct. The offset puts the origin at
(-250, 0, -250)
, then the scale makes the opposite corner-250 + 500 = 250
:(250, 0, 250)
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah alright, I mistook the offset as the center. I'll need to update CesiumGS/cesium#4183 as well.