Update pnts tile format spec to include batch table #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The image has a colors[] at the end still. |
|
Maybe worth adding that a default color will be used if no color semantics are present. |
Good eye, updated. |
Yes, updated. This is ready. |
|
Did you want to update the picture considering #103? I'm going to make the change in Cesium. |
|
Updated |
|
I merged this.. but is the "4 byte aligned array buffer" comment needed anymore? |
|
It is implicit given the 28-byte header, but I still think it is good to be precise and it may be needed depending on the final format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/AnalyticalGraphicsInc/3d-tiles/tree/pnts/TileFormats/Points
Add notes to keep it up-to-date with CesiumGS/cesium#4112
These are just notes; there will be more words when we flush out the spec.
Part of #22.