-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add NGA_gpm
validation
#319
Conversation
Merged in the specs that had been shown as a preview in #320 Added validation of aspects that are not covered by the JSON schema itself:
Added validation of aspects that are currently not covered by the JSON schema. This refers to aspects that are not covered by the current ("preview") version of the JSON schema, but - as confirmed via internal discussion - should become part of the schema, and therefore also be validated:
|
As mentioned above, one aspect of the validation is
We now encountered data sets that are likely supposed to be valid, and where these dot products had been in the range of |
This builds upon the state from #316 - that PR also provides some general context.
This adds support for the validation of the
NGA_gpm
extension, which is the 3D Tiles extension for GPM (corresponding toNGA_gpm_local
, which is the glTF extension).I'm opening this as a draft for now:
The last point is strongly related to #226 : I locally do have the necessary specs. But creating them was an odd mix of semi-automation and lots of (lots of) manual work, tweaking the files to be "broken" in one way or another, carefully matching the different ways of being "broken" with the spec and the schema. It still has to be decided whether another approach should be taken here.
A draft PR that shows the specs and the corresponding files is in #320
(Unrelated: I snuck in the (EDIT: specs for the) validation of the
3DTILES_bounding_volume_S2
extension here. The files for that already did exist. But the actual...Specs.ts
had been missing. This was only a minor fix that went along with the minor restructuring of the specs directory that I did for this PR)