Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Draco and Time Dynamic Point Cloud tilesets #150

Merged
merged 6 commits into from
Nov 8, 2018
Merged

Generate Draco and Time Dynamic Point Cloud tilesets #150

merged 6 commits into from
Nov 8, 2018

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Jul 5, 2018

Generates sample tilesets for CesiumGS/cesium#6721 and CesiumGS/cesium#6559

@@ -956,11 +1014,14 @@ function savePointCloudTileset(tilesetName, tileOptions, tilesetOptions) {
var result = createPointCloudTile(tileOptions);
var pnts = result.pnts;
var batchTableJson = result.batchTableJson;
var extensionsUsed = result.extensionsUsed;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an Extensions class in https://github.com/AnalyticalGraphicsInc/3d-tiles-tools/pull/149/files, do you want to use that?


var encodedLength = encoder.EncodePointCloudToDracoBuffer(pointCloud, false, encodedDracoDataArray);
if (encodedLength <= 0) {
throw 'Error: Encoding Failed.';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Draco encoding failed? Just so there's context if someone gets this error.

@lilleyse lilleyse mentioned this pull request Aug 29, 2018
4 tasks
@lilleyse
Copy link
Contributor Author

lilleyse commented Nov 8, 2018

@ggetz this is finally ready

@ggetz ggetz merged commit 2914e54 into master Nov 8, 2018
@ggetz
Copy link
Contributor

ggetz commented Nov 8, 2018

Thanks @lilleyse!

@ggetz ggetz deleted the draco branch November 8, 2018 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants