Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapping C++ struct #12

Merged
merged 10 commits into from
Jan 19, 2023
Merged

wrapping C++ struct #12

merged 10 commits into from
Jan 19, 2023

Conversation

sunayana
Copy link
Member

No description provided.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #39927: Improve wrapping of C++ code.

@sunayana
wrapping C++ struct
681bdd4
@sunayana
just testing
568f8a8
@sunayana
Adding member methods in jldepressions.cpp to wrap Depression in a wa…
783a4fd 
…y to access it from within julia

Co-authored-by: Cristiano Milia<[email protected]>
@sunayana
Merge branch 'feature/sc-39927/mapping-julia-cpp-struct' of github.co…
bff4db0 
…m:Cervest/richdem into feature/sc-39927/mapping-julia-cpp-struct

Co-authored-by: Cristiano Milia<[email protected]>
@sunayana sunayana force-pushed the feature/sc-39927/mapping-julia-cpp-struct branch from f181777 to bff4db0 Compare January 17, 2023 07:45
@sunayana sunayana changed the title [WIP] wrapping C++ struct wrapping C++ struct Jan 17, 2023
croissant-tmp
croissant-tmp approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@croissant-tmp croissant-tmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!
I was able to successfully reproduce in a container all the steps outlined in the ShortCut story 38122.

Libbum
Libbum approved these changes Jan 19, 2023
View reviewed changes
Copy link
Collaborator

@Libbum Libbum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we're good with method and implementation for the moment. We should spend some time writing up the design choices and tech debt (e.g. DepressionSubset -> Depression) for the release.

@sunayana sunayana merged commit ab19bc5 into master Jan 19, 2023
@sunayana sunayana deleted the feature/sc-39927/mapping-julia-cpp-struct branch January 19, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Libbum Libbum Libbum approved these changes

@croissant-tmp croissant-tmp croissant-tmp approved these changes

@maximerischard maximerischard Awaiting requested review from maximerischard

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunayana @Libbum @croissant-tmp