fix: Preserve padding in tuple-based declarations #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Previously, in a declaration of the form
(,uint a, uint b) = ...
the leading "padded" position was removed from the AST during a pre-processing step that converted declarations into assignments. The caused the variablesa
andb
to get assigned to components0
and1
instead of1
and2
.This PR preserves the padding during the AST transformation.
Testing
make test
and verify that tests succeed./evaluate.sh run 100
intool-eval
and verify that projects succeed.Try viewing the IR for this test file:
Related Issue
https://github.com/CertiKProject/slither-task/issues/539
See also: crytic#1913