Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support CustomError as a type of finding generated in detectors #4

Merged
merged 1 commit into from
Jun 16, 2022
Merged

feat: support CustomError as a type of finding generated in detectors #4

merged 1 commit into from
Jun 16, 2022

Conversation

runmingl
Copy link

duckki
duckki approved these changes Jun 16, 2022
View reviewed changes
Copy link

@duckki duckki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

If we were to reimplement Slither, I would make "output" as a virtual function of each class. Instead of cast-splitting in output.py.

@duckki duckki merged commit d4bd7ca into certik Jun 16, 2022
@chenhuitao chenhuitao deleted the custom-error branch March 18, 2024 10:40
whonore pushed a commit that referenced this pull request May 24, 2024
@whonore
feat: support CustomError as a type of finding generated in detectors (…
88b213d 
…#4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckki duckki duckki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@runmingl @duckki