Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Populate source location for using_for construct #1

Merged
merged 4 commits into from
May 24, 2022

Conversation

runmingl
Copy link

Populate the source location for using_for construct in order to facilitate the analysis of https://github.com/CertiKProject/slither-task/issues/71

@runmingl runmingl requested a review from duckki May 23, 2022 22:49
@runmingl runmingl changed the base branch from master to certik May 23, 2022 22:50
Copy link

@duckki duckki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good overall. I'm suggesting a minor change.

slither/solc_parsing/declarations/contract.py Show resolved Hide resolved
slither/solc_parsing/declarations/contract.py Outdated Show resolved Hide resolved
@runmingl runmingl requested a review from duckki May 24, 2022 00:53
Copy link

@duckki duckki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@duckki duckki merged commit 6d71e15 into certik May 24, 2022
runmingl pushed a commit that referenced this pull request May 26, 2022
runmingl pushed a commit that referenced this pull request May 26, 2022
runmingl pushed a commit that referenced this pull request May 26, 2022
duckki pushed a commit that referenced this pull request Dec 5, 2022
Merge `dev` into `patch-1`
whonore pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants