lib: mark URL/URLSearchParams as uncloneable and untransferable

Mark URL/URLSearchParams as uncloneable and untransferable to reject them in `structuredClone` and `port.postMessage`. PR-URL: nodejs#47497 Refs: nodejs#47214 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Ceres6 · Aug 14, 2023 · 2425f2a · 2425f2a
1 parent faf73fe
commit 2425f2a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/lib/internal/url.js b/lib/internal/url.js
@@ -47,6 +47,10 @@ const {
   SideEffectFreeRegExpPrototypeSymbolReplace,
 } = require('internal/util');
 
+const {
+  markTransferMode,
+} = require('internal/worker/js_transferable');
+
 const {
   codes: {
     ERR_ARG_NOT_ITERABLE,
@@ -326,6 +330,8 @@ class URLSearchParams {
   // Default parameter is necessary to keep URLSearchParams.length === 0 in
   // accordance with Web IDL spec.
   constructor(init = undefined) {
+    markTransferMode(this, false, false);
+
     if (init == null) {
       // Do nothing
     } else if (typeof init === 'object' || typeof init === 'function') {
@@ -761,6 +767,8 @@ class URL {
   #searchParams;
 
   constructor(input, base = undefined) {
+    markTransferMode(this, false, false);
+
     if (arguments.length === 0) {
       throw new ERR_MISSING_ARGS('url');
     }

diff --git a/test/wpt/status/url.json b/test/wpt/status/url.json
@@ -6,9 +6,7 @@
     "fail": {
       "note": "We are faking location with a URL object for the sake of the testharness and it has searchParams.",
       "expected": [
-        "searchParams on location object",
-        "URL: no structured serialize/deserialize support",
-        "URLSearchParams: no structured serialize/deserialize support"
+        "searchParams on location object"
       ]
     }
   },