Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Devync/ng 17 #50

Merged
merged 6 commits into from
Jun 5, 2024
Merged

Devync/ng 17 #50

merged 6 commits into from
Jun 5, 2024

Conversation

Devcon4
Copy link
Collaborator

@Devcon4 Devcon4 commented Jun 5, 2024

Description

Update Centeva-Angular to angular 17.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Tests
  • 🤖 Build/CI
  • 📦 Chore (Version bump, release, etc.)
  • ⏩ Revert

Changes Made

  • Bumped Angular to 17.
  • Bumped Material to 17.
  • Update peerDependencies.

@Devcon4 Devcon4 requested a review from pdeffendol June 5, 2024 16:22
pdeffendol
pdeffendol approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@pdeffendol pdeffendol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what to review here. No code changes needed?

I assume you've tested to make sure it works.

Have you considered splitting this into two packages, one with the Material-derived components, and the other with the pipes, etc. (I know, off-topic.)

@Devcon4 Devcon4 merged commit cb4b2c1 into master Jun 5, 2024
1 check passed
@Devcon4 Devcon4 deleted the devync/ng-17 branch June 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maestro957 maestro957 maestro957 approved these changes

@pdeffendol pdeffendol pdeffendol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Devcon4 @pdeffendol @maestro957