Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-688] Validated Form-Controls #721

Merged

Conversation

baylee-d
Copy link

Purpose

In preparation for registries submission forms, we need to create form controls that take a changeset and output a group of form elements.

Summary of Changes

  • Add form-controls component
  • Add form-controls section to handbook
  • Update x-input-wrapper on the validated-input component to take in an optional id param

Side Effects

N/A

Feature Flags

N/A

QA Notes

This isn't being used anywhere on the site yet, so it shouldn't need QA.

Ticket

https://openscience.atlassian.net/browse/ENG-688

Still to do

  • Add tests
  • Update changelog
  • Put back form elements (recaptcha)

Reviewer Checklist

  • meets requirements
  • easy to understand
  • DRY
  • testable and includes test(s)
  • changes described in CHANGELOG.md

@baylee-d baylee-d force-pushed the feature/form-controls branch from fe52b87 to ac40450 Compare July 25, 2019 15:57
@coveralls
Copy link

coveralls commented Jul 25, 2019

Pull Request Test Coverage Report for Build 3200

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.008%) to 75.59%

Files with Coverage Reduction New Missed Lines %
lib/osf-components/addon/components/validated-model-form/component.ts 7 82.46%
Totals Coverage Status
Change from base Build 3194: -0.008%
Covered Lines: 6876
Relevant Lines: 7994

💛 - Coveralls

Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First-pass CR

lib/handbook/addon/docs/template.hbs Outdated Show resolved Hide resolved
lib/handbook/addon/routes.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@baylee-d baylee-d force-pushed the feature/form-controls branch 2 times, most recently from 7f740d5 to ee87872 Compare August 1, 2019 20:39
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small things.

lib/handbook/package.json Outdated Show resolved Hide resolved
lib/handbook/package.json Outdated Show resolved Hide resolved
@jamescdavis jamescdavis changed the title [Draft][ENG-688] Validated Form-Controls [ENG-688] Validated Form-Controls Aug 2, 2019
@baylee-d baylee-d force-pushed the feature/form-controls branch from aa74e64 to d4c1e2e Compare August 2, 2019 19:27
Copy link
Member

@jamescdavis jamescdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jamescdavis jamescdavis merged commit 3e966de into CenterForOpenScience:develop Aug 3, 2019
@jamescdavis jamescdavis added this to the Nitrogen milestone Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants