-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENG-688] Validated Form-Controls #721
[ENG-688] Validated Form-Controls #721
Conversation
fe52b87
to
ac40450
Compare
Pull Request Test Coverage Report for Build 3200
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First-pass CR
lib/handbook/addon/docs/components/form-controls/demo-default/template.hbs
Show resolved
Hide resolved
7f740d5
to
ee87872
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small things.
aa74e64
to
d4c1e2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
Purpose
In preparation for registries submission forms, we need to create form controls that take a changeset and output a group of form elements.
Summary of Changes
form-controls
componentform-controls
section to handbookx-input-wrapper
on thevalidated-input
component to take in an optional id paramSide Effects
N/A
Feature Flags
N/A
QA Notes
This isn't being used anywhere on the site yet, so it shouldn't need QA.
Ticket
https://openscience.atlassian.net/browse/ENG-688
Still to do
Reviewer Checklist
CHANGELOG.md