-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unchaining WIP-Release v0.1.43-alpha #868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (304 of 304 strings)
Currently translated at 99.6% (303 of 304 strings)
Feature/realm
and remove some useless comments
Currently translated at 100.0% (291 of 291 strings)
Consistent spelling of neighboring to fix #865
Currently translated at 100.0% (291 of 291 strings)
rshddb40
approved these changes
Jul 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Cant open |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the wonderful work of @larsgrefer, we're now using a new and hopefully much better to manage realm java database. Our current database design looks like this:
Other important details:
We display the Neighboring Cell information in two ways:
(Data is saved in an Array not in an table)
I strongly encourage all members of @CellularPrivacy/database to check out the latest changes and see if you can improve his work. @E3V3A, please don't be mad at me for merging this. Even though you did not respond in the pull request for this major change, I very much hope you will value the advantages of this new database - see #215 (comment): "We don't have to worry about OR-Mapping and get a nice java-api. And of course we can get rid of our 2000+ lines monster-class". Enjoy another fine release!