Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a logging interface #670

Merged
merged 6 commits into from
Dec 8, 2015
Merged

Use a logging interface #670

merged 6 commits into from
Dec 8, 2015

Conversation

larsgrefer
Copy link
Collaborator

not ready to merge yet

@SecUpwN
Copy link
Member

SecUpwN commented Dec 8, 2015

@larsgrefer, when pressing Debugging in our app the log appears. What are you trying to do?

@larsgrefer
Copy link
Collaborator Author

Don't use android.util.Log directly, but use an Interface + android-specific Implemenation

just have a look at the diff

@SecUpwN
Copy link
Member

SecUpwN commented Dec 8, 2015

just have a look at the diff

I did, it now makes sense: You're just changing the way we log stuff, displaying it stays the same.
I'm granting permission to you to merge this whenever you feel it is ready. See ya later, aligator!

@larsgrefer larsgrefer self-assigned this Dec 8, 2015
@larsgrefer larsgrefer added this to the v0.1.37-alpha milestone Dec 8, 2015
larsgrefer added a commit that referenced this pull request Dec 8, 2015
@larsgrefer larsgrefer merged commit 24a0ef2 into development Dec 8, 2015
@SecUpwN
Copy link
Member

SecUpwN commented Dec 9, 2015

Since branch feature/logging still exists, could you also have a look at #201, #208 and #583? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants